fix Combobox z-index stack order issue #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnbaaij
approved these changes
Dec 22, 2023
dvoituron
requested changes
Dec 22, 2023
| } | ||
|
|
||
| <style> | ||
| @($"#{Id}::part(listbox) {{ max-height: {(string.IsNullOrEmpty(Height) ? null : Height)}; z-index: {ZIndex.ComboboxPopup} }}") |
There was a problem hiding this comment.
Could you modify the generation of this "string", because when "height" is not defined, the style still contains a "height" attribute.
Example
<style>#combobox::part(listbox) { max-height: ; z-index: 9995 }</style>There was a problem hiding this comment.
Sure. I'll amend the changes
There was a problem hiding this comment.
I'm going to be annoying but it's my job 😎. Can you add a space after the max-height? To be consistent with the rest of the generated code.
And it's probably clearer to do $"max-height: {Height};".
dromerolovo
force-pushed
the
fix/combobox-z-stack
branch
from
63315e7 to
f17d21b
Compare
vnbaaij
approved these changes
Dec 22, 2023
|
@dvoituron I knew you were going to say that! 😂 |
dvoituron
approved these changes
Dec 23, 2023
vnbaaij
added a commit
that referenced
this pull request
Dec 28, 2023
* fix Combobox z-index stack order issue * fix Combobox z-index stack order issue --------- Co-authored-by: Vincent Baaij <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves #1188